Skip to content

config(amazonq): patch #5965 #5968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2024
Merged

config(amazonq): patch #5965 #5968

merged 2 commits into from
Nov 9, 2024

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Nov 8, 2024 •
edited
Loading

Problem

not clear why is this but these lines will make client generated not able to call the service correctly and seems it always timeout.

https://github.com/aws/aws-toolkit-vscode/pull/5965/files#diff-1993309d74a00d453d972baa185cc65e227911391f8de06add4ee0998684e638R5-R12

Solution

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Nov 8, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review November 8, 2024 23:33
@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner November 8, 2024 23:33
@Will-ShaoHua Will-ShaoHua changed the title patch #5965 config(amazonq): patch #5965 Nov 8, 2024
@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Nov 8, 2024

/retryBuilds

@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Nov 8, 2024 

2974 passing (2m)
  15 pending
  1 failing
  1) SamCliLocalInvokeInvocation
       invokes `sam local` with args:
     Error: Test length exceeded max duration: 30 seconds

@justinmk3 justinmk3 merged commit eac87bc into aws:master Nov 9, 2024
9 of 17 checks passed
@Will-ShaoHua Will-ShaoHua deleted the api-update branch November 9, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctlai95 ctlai95 ctlai95 approved these changes

+1 more reviewer

@hayemaxi hayemaxi hayemaxi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Will-ShaoHua @ctlai95 @hayemaxi @justinmk3